Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VM password restrictions #87

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Fix VM password restrictions #87

merged 1 commit into from
Jun 28, 2017

Conversation

djberg96
Copy link
Collaborator

This fixes the VM password restrictions to match the actual Azure password restrictions for virtual machines. The rules are that the password must at least 12 characters long and match at least 3 of the following 4 conditions:

  • Contain 1 lowercase character
  • Contain 1 uppercase character
  • Contain 1 number
  • Contain 1 special character

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1454812

@bronaghs
Copy link

@djberg96 - I don't think a minimum of 12 characters meets the requirements:
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update

@miq-bot
Copy link
Member

miq-bot commented Jun 28, 2017

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/4a188f621902737354b876430ac4bcb11b269657 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@djberg96
Copy link
Collaborator Author

@bronaghs The documentation is wrong. From the Azure portal:

screen shot 2017-06-28 at 10 27 39 am

@bronaghs
Copy link

@djberg96 Ah, interesting.

@bronaghs bronaghs merged commit c77d8d3 into ManageIQ:master Jun 28, 2017
@bronaghs bronaghs added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 28, 2017
@bronaghs bronaghs added the bug label Jun 28, 2017
@bronaghs
Copy link

@djberg96 - any reason why this shouldnt be backported to fine?

@djberg96
Copy link
Collaborator Author

@miq-bot add_label fine/yes

@djberg96
Copy link
Collaborator Author

@bronaghs You must have beat me to it by seconds. ;)

Yes, it should be backported. Already tagged.

@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit 63beac76d18e8ccf17546207d28f8328d1000b7c
Author: Bronagh Sorota <[email protected]>
Date:   Wed Jun 28 12:32:12 2017 -0400

    Merge pull request #87 from djberg96/vm_password_regex
    
    Fix VM password restrictions
    (cherry picked from commit c77d8d32c035bd5e5d1cc29ccaa3baf7f9edcc3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants