Disable metrics and events in unsupported regions #36
Conversation
|
@miq-bot add_label wip |
|
@djberg96 Cannot apply the following label because they are not recognized: wip |
|
Note to self: as per conversation with the UI folks, we may want to add a textual summary for the UI at app/helpers/ems_cloud_helper/textual_summary.rb (in the classic-ui repo). |
djberg96
changed the title
|
@miq-bot remove_label wip |
| @@ -1,3 +1,5 @@ | |||
| require 'azure-armrest' | |||
There was a problem hiding this comment.
wont this already be required by connect ?
There was a problem hiding this comment.
I was hitting some kind of weird load ordering issue that I couldn't nail down, which resulted in undefined constant errors.
| @@ -183,6 +183,13 @@ def raw_metrics_for_counter(storage_conn, counter, start_time, end_time) | |||
| end | |||
|
|
|||
| def get_counters(metrics_conn) | |||
| ems = target.ext_management_system | |||
|
|
|||
| unless ems.supports_timeline? | |||
There was a problem hiding this comment.
would this be better ems.insights? to not conflate with timelines / events ?
There was a problem hiding this comment.
Yes, probably. I will update.
| @@ -183,6 +183,13 @@ def raw_metrics_for_counter(storage_conn, counter, start_time, end_time) | |||
| end | |||
|
|
|||
| def get_counters(metrics_conn) | |||
| ems = target.ext_management_system | |||
|
|
|||
| unless ems.supports_timeline? | |||
There was a problem hiding this comment.
@djberg96 - I would probably move this to line 78 after we check for an EMS, this would keep the checks together and avoid calling methods if metrics isn't supported. Or is there a reason for placing this line here?
There was a problem hiding this comment.
I'll try it and report back.
There was a problem hiding this comment.
@bronaghs Ok, I've moved it as you suggested. Seems to work just as well there.
There was a problem hiding this comment.
@bronaghs Upon further review it seems to cause test failures because of with_provider_connection which is called again later within the same method. I've moved it back for now.
Update get_counter to skip counter collection if timeline isn't supported. Added supports feature specs. Initial commit.
|
Checked commits https://github.com/djberg96/manageiq-providers-azure/compare/98c982ddb15d0ac60e0a3b70761ab1bde61c9bd4~...8d18453d847ba408a5876e6c9482c95091f8288f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This PR uses the SupportsFeatureMixin and the most recent azure-armrest gem to disable metrics and events collection in regions that are not supported.
Note that this requires the addition of
:metricsto the support matrix. See ManageIQ/manageiq#13381You will also have to update gems-pending-config to point to azure-armrest 0.6.0.