Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all resources when deleting an Azure stack #24

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Jan 16, 2017

Azure API by default does not delete associated resources of a stack. In azure-armrest we made it possible to delete all associated resources together with a deployment.

We now make this default behavior for upstream, but for previous versions we should make it only optional in order not to surprise existing users. Therefore this change should not be auto back ported.

@djberg96 please review.

@bzwei bzwei force-pushed the delete_all_resources branch from 96833af to 71e9ea4 Compare January 16, 2017 14:26
@bzwei
Copy link
Contributor Author

bzwei commented Jan 16, 2017

@miq-bot add_label euwe/no

@bzwei
Copy link
Contributor Author

bzwei commented Jan 16, 2017

@miq-bot remove_label euwe/no
Will need to back port to euwe and darga, but through separate PRs.

@miq-bot miq-bot removed the euwe/no label Jan 16, 2017
@djberg96
Copy link
Collaborator

👍

@simaishi
Copy link
Contributor

Backported to Darga via ManageIQ/manageiq#13547

@simaishi
Copy link
Contributor

Backported to Euwe via ManageIQ/manageiq#13548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants