Allowed cloud network without a zone should return everything #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally merged erroneously because Travis run didn't complete all tests
|
Checked commit d-m-u@759b8f9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Discussed with @d-m-u and identified the reason the test was passing initially. (Now documented in the PR description). |
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
Allowed cloud network without a zone should return everything (cherry picked from commit 4df4696)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally merged erroneously because Travis run didn't complete all tests on #199. If it had, I think it would've failed due to the error this fixes. It passed originally because the call to all_cloud_networks was wrong and got fixed here: https://github.com/ManageIQ/manageiq/pull/16824/files. Before the last PR got merged, this test would've been correct as the call erroneously returned nothing. Since the merge of ManageIQ/manageiq#16824, the call for azure returns everything, and thus this test needs to change.
Should return all, not none, due to https://github.com/d-m-u/manageiq/blob/59ba714ccb71b2eb3cdd46157587e85329af4f3b/app/models/manageiq/providers/cloud_manager/provision_workflow.rb#L98.
related bzs:
Fixes issue caused by fix of https://bugzilla.redhat.com/show_bug.cgi?id=1533277
(Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535189)