Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files killing embedded refresh #97

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Missing files killing embedded refresh #97

merged 1 commit into from
Jun 13, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Jun 13, 2018

#81 removed the 2 files that the embedded code still depends on. And manageiq repo build is failing

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels bug
@agrare @slemrmartin please take a look

@miq-bot miq-bot added the bug label Jun 13, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2018

Checked commit https://github.com/jameswnl/manageiq-providers-ansible_tower/commit/b99f2bce78e3533894c1785d2185b022affe94b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixes CI, until @slemrmartin does a proper fix, using the new interface

@Ladas Ladas self-assigned this Jun 13, 2018
@Ladas Ladas merged commit e0ce085 into ManageIQ:master Jun 13, 2018
@Ladas Ladas added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants