Add ansible_tower_client dependency to Gemspec #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gem does not list any runtime dependencies in its Gemspec. It however it actually has some and it is not a good practice to rely on manageiq’s Gemfile to satisfy them. Add at least ansible_tower_client for now as it is the most clear dependency.
14 tasks
|
Checked commit Glutexo@7fdbc8d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
3 tasks
jameswnl
approved these changes
May 31, 2018
jameswnl
reviewed
May 31, 2018
| @@ -13,6 +13,8 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.files = Dir["{app,config,lib}/**/*"] | |||
|
|
|||
| s.add_runtime_dependency "ansible_tower_client", "~> 0.13.0" | |||
There was a problem hiding this comment.
@Glutexo please create a new one for 0.14 as ansible/ansible_tower_client_ruby@6e8eef4
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem does not list any runtime dependencies in its Gemspec. However it actually has some and it is not a good practice to rely on
manageiq’s Gemfile to satisfy them.Add at least ansible_tower_client for now as it is the most clear dependency. Besides it being an actual dependency it shows a little that the dependencies really should be put in there.
Currently it lists
v0.13.0, the same version asmanageiqitself. If #72 would be merged before this PR, the version has to be bumped tov0.14.0, like in ManageIQ/manageiq#17290.@miq-bot add_reviewer @jameswnl