Re-record vcr cassette and spec update, plus a script to generate Tower objects #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswnl
changed the title
|
@miq-bot add_label wip |
jameswnl
changed the title
|
@miq-bot remove_label wip |
|
@miq-bot add_label test |
|
thats great. I really like an reproducible way of generating those cassettes. How about making that script a rake task like here and also add some docs to the tasks? |
|
@durandom good suggestion. Now it's a rake task. |
|
@durandom - good to merge? |
durandom
approved these changes
Jun 23, 2017
lib/tasks_private/spec_helper.rake
Outdated
| @@ -0,0 +1,157 @@ | |||
| namespace :manageiq do | |||
| namespace :providers do | |||
| namespace :ansible_tower do | |||
There was a problem hiding this comment.
I dont think this should be nested under manageiq:providers
This task is only visible inside the ansible tower gem.
Maybe spec:populate_tower ? because it's spec related?
There was a problem hiding this comment.
Yes, I agree. I copied this namespace from the existing rake file. Will update it
|
Some comments on commits https://github.com/jameswnl/manageiq-providers-ansible_tower/compare/149136d49abccfb786302fbb1fdf2604f5b0cb96~...cefc65ab133663fcbae8f35f0f34932b1723acd8 lib/tasks_private/spec_helper.rake
spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher.yml
|
|
Checked commits https://github.com/jameswnl/manageiq-providers-ansible_tower/compare/149136d49abccfb786302fbb1fdf2604f5b0cb96~...cefc65ab133663fcbae8f35f0f34932b1723acd8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jameswnl - Fine yes or no? |
|
@miq-bot add_labels fine/yes |
|
@jameswnl This doesn't cherry-pick cleanly, and I'm not sure how to resolve conflicts. Can you please create a PR for Fine branch? |
|
@simaishi please merge the others first and I'll make a PR for this one. I'll need to re-record the cassette. |
|
Backported to Fine via ManageIQ/manageiq#15780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manageiq:providers:ansible_tower:populate_towerwhich will re-create a set of Tower objectsrefresher.rbspec to match those created by the step aboveNext time, to add new specs for refresh,
manageiq:providers:ansible_tower:populate_towerrefresher.rb