Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ansible Shared specs from ManageIQ repo #5

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Adding Ansible Shared specs from ManageIQ repo #5

merged 1 commit into from
Jun 15, 2017

Conversation

juliancheal
Copy link
Member

We missed this folder during extraction original files from
https://github.com/ManageIQ/manageiq/tree/master/spec/support/ansible_shared

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2017

Some comments on commit 7687da1

spec/support/ansible_shared/automation_manager/configuration_script.rb

  • ⚠️ - 39 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/support/ansible_shared/automation_manager/job.rb

  • ⚠️ - 115 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 144 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 72 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2017

Checked commit 7687da1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
12 files checked, 1 offense detected

spec/support/ansible_shared/provider.rb

  • ❗ - Line 25, Col 48 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@juliancheal
Copy link
Member Author

❗️ - Line 25, Col 48 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

In this instance when you align the hashes it makes the code look really unreadable.

@bronaghs bronaghs merged commit 8320477 into ManageIQ:master Jun 15, 2017
@bronaghs bronaghs added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants