Add missing VCR Cassettes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing PR after gitter discussion to keep VCR cassettes in main ManageIQ repo for now, as they are shared by Embedded Ansible. |
|
Checked commit 38beeb0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Some comments on commit 38beeb0 spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher.yml
spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher_credentials.yml
spec/vcr_cassettes/manageiq/providers/ansible_tower/automation_manager/refresher_v2.yml
|
|
@juliancheal - Why was this reopened? I see it was closed deliberately after a gitter discussion. |
After another conversation it was decided the cassettes should live in this repo https://gitter.im/ManageIQ/manageiq-providers-ansible_tower?at=594187e1cf9c13503c874006 |
This was referenced Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.