Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safe_load calls to work with psych 3/4 #837

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jrafanie
Copy link
Member

Part of ManageIQ/manageiq#22696

Keep compatibility with psych 3.1+ since permitted_classes and aliases were added as keyword arguments to safe_load.

Note, psych 4 changed the interface to drop support with positional arguments for the permitted_classes. Now, we must explicitly specify them using kwargs.

Part of ManageIQ/manageiq#22696

Keep compatibility with psych 3.1+ since permitted_classes and aliases were
added as keyword arguments to safe_load.

Note, psych 4 changed the interface to drop support with positional arguments for the permitted_classes.
Now, we must explicitly specify them using kwargs.
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2023

Checked commit jrafanie@44d5263 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy merged commit 2a0b7be into ManageIQ:master Nov 14, 2023
2 checks passed
@jrafanie jrafanie deleted the psych4_support branch January 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants