Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports label mapping in cloud manager #669

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Nov 5, 2020

No description provided.

@lpichler lpichler force-pushed the supports_label_mapping branch from eca712e to 90ab3a8 Compare November 5, 2020 11:04
@miq-bot miq-bot added the wip label Nov 5, 2020
@lpichler lpichler force-pushed the supports_label_mapping branch 2 times, most recently from aee200f to 6452fe7 Compare November 5, 2020 16:20
@agrare
Copy link
Member

agrare commented Nov 9, 2020

@lpichler could you update this so that it doesn't depend on ManageIQ/manageiq-schema#525?
I'd like to be able to merge this independently of that

@lpichler lpichler force-pushed the supports_label_mapping branch from 6452fe7 to 858de3a Compare November 10, 2020 13:53
@lpichler lpichler changed the title [WIP] Supports label mapping in cloud manager Supports label mapping in cloud manager Nov 10, 2020
@lpichler
Copy link
Contributor Author

@lpichler could you update this so that it doesn't depend on ManageIQ/manageiq-schema#525?
I'd like to be able to merge this independently of that

@agrare Done 👍

@miq-bot miq-bot removed the wip label Nov 10, 2020
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2020

This pull request is not mergeable. Please rebase and repush.

@lpichler lpichler force-pushed the supports_label_mapping branch from 858de3a to 84492ff Compare November 12, 2020 16:50
@miq-bot
Copy link
Member

miq-bot commented Nov 12, 2020

Checked commit lpichler@84492ff with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@lpichler
Copy link
Contributor Author

@miq-bot remove_label unmergeable

@agrare agrare self-assigned this Nov 18, 2020
@agrare agrare merged commit 1813788 into ManageIQ:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants