Fix missing MiqServer in Authenticator spec #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: ManageIQ/manageiq#17508 👍 |
The new audit_failure method in authenticator/base raises an evm event on auth failure which targets the MiqServer.my_server. In the amazon authenticator spec this was nil which was causing the audit_failure method to throw an exception trying to get class and id from the target. https://bugzilla.redhat.com/show_bug.cgi?id=1318353
agrare
force-pushed
the
fix_authenticator_spec_missing_miq_server
branch
from
c6b8599 to
4cafc5f
Compare
|
Checked commit agrare@4cafc5f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new audit_failure method in authenticator/base raises an evm event
on auth failure which targets the MiqServer.my_server. In the amazon
authenticator spec this was nil which was causing the audit_failure
method to throw an exception trying to get class and id from the target.
https://bugzilla.redhat.com/show_bug.cgi?id=1318353