Renamed method for consistency reasons #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romanblanco - if you rebase and push the test failures around |
romanblanco
force-pushed
the
cloud_object_store_object_consistency
branch
from
32802c6 to
122d16a
Compare
romanblanco
force-pushed
the
cloud_object_store_object_consistency
branch
from
122d16a to
0f88049
Compare
|
Checked commit romanblanco@0f88049 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bronaghs
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR should be merged together with the PR to the core repo: ManageIQ/manageiq#17143
Related to the changes in:
ManageIQ/manageiq#17143
ManageIQ/manageiq-ui-classic#3607
cc @miha-plesko