Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate model display names from locale/en.yml to plugin #398

Merged

Conversation

mzazrivec
Copy link
Contributor

This is a continuation of the work started in ManageIQ/manageiq#16596 where we want to migrate display model names from locale/en.yml into particular models, where we'll use standard gettext. Main goal here is to make this one aspect of our application pluggable.

Core PR: ManageIQ/manageiq#16836

@bronaghs
Copy link

hi @mzazrivec - Once you rebase, the specs should pass.

@mzazrivec mzazrivec force-pushed the migrate_display_names_for_models branch from 048adf2 to 95b089d Compare January 19, 2018 07:15
@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Checked commit mzazrivec@95b089d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec
Copy link
Contributor Author

@bronaghs Rebased, thanks.

@bronaghs bronaghs self-assigned this Jan 19, 2018
@bronaghs bronaghs merged commit 365c642 into ManageIQ:master Jan 19, 2018
@bronaghs bronaghs added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 19, 2018
@mzazrivec mzazrivec deleted the migrate_display_names_for_models branch January 19, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants