Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tag mapping in graph refresh #382

Merged
merged 9 commits into from
Jan 4, 2018
Merged

Implement tag mapping in graph refresh #382

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6141841
Check tag mapping in VCR refresher specs
cben Dec 21, 2017
8468ba4
Tag mapping in graph refresh: find/create Tags
Jan 2, 2018
bfb0cdf
Tag mapping in graph refresh: assign Taggings
Jan 3, 2018
e0b279d
map image tags
cben Jan 3, 2018
281bad5
Check tag mapping on images
cben Jan 3, 2018
1ae5cf7
Check VM mapped tags from assert_specific_vm_*
cben Jan 3, 2018
2b85fe1
Move tag Mapper from parser to persister
cben Jan 4, 2018
307a608
drop redundant taggable_type constraint
cben Jan 4, 2018
688cf2f
Fix taggings targeted_arel to actually be targeted!
cben Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/amazon/inventory_collection_default/cloud_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def vm_and_template_taggings(extra_attributes = {})
manager_uuids = inventory_collection.parent_inventory_collections.collect(&:manager_uuids).map(&:to_a).flatten
ems = inventory_collection.parent
ems.vm_and_template_taggings.where(
'taggable_id' => ems.vms_and_templates(:ems_ref => manager_uuids)
'taggable_id' => ems.vms_and_templates.where(:ems_ref => manager_uuids)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah :-o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha that'll do it

)
end

Expand Down