Refresh operating system and fix normalized guest os #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OperatingSystem to new refresh and fix normalized guest_os Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1521018
Test we refresh correct operating system
Fix targeted refresh specs
Add FIXME to remember the guest_os duplicated information
Add OperatingSystem to old refresh and fix normalized guest_os
Fix old specs after adding OperatingSystem
Fix stubbed specs to have also disconnected OperatingSystem
Ladas
commented
Dec 6, 2017
| @@ -171,10 +171,10 @@ def self.key_pair_type | |||
| def parse_image(image, is_public) | |||
| uid = image.image_id | |||
| location = image.image_location | |||
| guest_os = (image.platform == "windows") ? "windows" : "linux" | |||
| if guest_os == "linux" | |||
| guest_os = (image.platform == "windows") ? "windows_generic" : "linux_generic" | |||
There was a problem hiding this comment.
@blomquisg any idea why we've used linux&windows as guest os? The allowed normalized names are only windows_generic and linux_generic, from https://github.com/Ladas/manageiq/blob/6eeec01542e27442e0d6515c39417abc0470b42b/app/models/operating_system.rb#L13
Fix rubocop issues
|
Checked commits Ladas/manageiq-providers-amazon@ad7ec90~...467a85e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Dec 7, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…ormalized_guest_os Refresh operating system and fix normalized guest os (cherry picked from commit e8eb2a7) https://bugzilla.redhat.com/show_bug.cgi?id=1524572
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Refresh operating system and fix normalized guest os, so it shows up correctly in the landing page reports.
Partially fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1521018
Before:
After this PR, refresh and regeneration of the dashboard widget (the uknown guest of is shown only for archived Vms, since refresh doesn't touch those):
