Add smartstate_docker authtype #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the additional smartstate_docker authentication type to be used for Docker Registry login on the remote AWS instance running smartstate.
|
@miq-bot add_label smartstate |
|
@jerryk55 Cannot apply the following label because they are not recognized: smartstate |
|
@jerryk55 Cannot apply the following label because they are not recognized: "smart state" |
|
Checked commit jerryk55@7e15bed with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
roliveri
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the additional smartstate_docker authentication type
to be used for Docker Registry login on the remote AWS instance running smart state.
This change goes hand-in-hand with the UI PR under separate cover which relies on this to succeed.
@roliveri @hsong-rh @Fryguy @bronaghs please review and merge when ready.