Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test result to match new data_type #272

Conversation

syncrou
Copy link
Contributor

@syncrou syncrou commented Jul 14, 2017

The security_groups key now defaults to a data_type of :array_integer. The resulting value is an Array of Integers as opposed to an array with the first value being an integer and the second being a human readable value.

This fix modifies the resulting hash to expect an array of Integers.

Dependent on: ManageIQ/manageiq#15572

The security_groups key now defaults to a data_type of :array_integer.  The resulting value is an Array of Integers
as opposed to an array with the first value being an integer and the second being a human readable value.  This fix modifies the resulting
hash to expect an array of Integers.
@syncrou
Copy link
Contributor Author

syncrou commented Jul 14, 2017

@miq-bot add_label bug

@miq-bot assign @durandom

cc - @gmcculloug, @imtayadeway

@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2017

Checked commit syncrou@dee4339 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@syncrou syncrou closed this Jul 18, 2017
@syncrou syncrou reopened this Jul 18, 2017
@gmcculloug gmcculloug merged commit f19e6f1 into ManageIQ:master Jul 18, 2017
@gmcculloug gmcculloug added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 18, 2017
@durandom
Copy link
Member

👏 thanks @syncrou and thanks @gmcculloug for merging 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants