Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ruby to 2.3.3 and add 2.4.1 #245

Merged
merged 1 commit into from
May 5, 2017
Merged

bump ruby to 2.3.3 and add 2.4.1 #245

merged 1 commit into from
May 5, 2017

Conversation

durandom
Copy link
Member

@durandom durandom commented May 3, 2017

@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

Checked commit durandom@4a06e18 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@durandom durandom mentioned this pull request May 3, 2017
Closed
54 tasks
jrafanie
jrafanie approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie
Copy link
Member

jrafanie commented May 4, 2017

@durandom @Fryguy I don't merge rights here but LGTM

@Fryguy Fryguy merged commit ecf64fb into ManageIQ:master May 5, 2017
@Fryguy Fryguy added this to the Sprint 60 Ending May 8, 2017 milestone May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durandom @miq-bot @jrafanie @Fryguy