Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zookeeper from operator #952

Closed
wants to merge 1 commit into from

Conversation

nasark
Copy link
Member

@nasark nasark commented Mar 31, 2023

With the introduction of KRaft, Zookeeper is no longer needed and can be removed

Depends on:

Ref:

@miq-bot assign @bdunne
@miq-bot add_reviewer @Fryguy
@miq-bot add_label enhancement

@nasark nasark requested a review from bdunne as a code owner March 31, 2023 20:49
@miq-bot miq-bot requested a review from Fryguy March 31, 2023 20:50
@nasark
Copy link
Member Author

nasark commented Mar 31, 2023

This can be cherry picked to #951 if you prefer. Keeping it separate at the moment for simplicity

Also will this require a CR migration? @Fryguy

@nasark nasark mentioned this pull request Mar 31, 2023
5 tasks
@nasark nasark force-pushed the remove_zookeeper branch from f8db95f to f5d95a6 Compare April 10, 2023 13:38
@nasark
Copy link
Member Author

nasark commented Apr 10, 2023

  • keeping zookeeper in the CR and added deprecation comments

@nasark nasark force-pushed the remove_zookeeper branch from f5d95a6 to 4b5723d Compare April 19, 2023 20:05
@nasark nasark force-pushed the remove_zookeeper branch from 4b5723d to 8bb66a2 Compare April 19, 2023 20:11
@@ -335,36 +335,36 @@ type ManageIQSpec struct {
// +optional
WebserverWorkerImage string `json:"webserverWorkerImage,omitempty"`

// Zookeeper deployment CPU limit (default: no limit)
// Deprecated: Zookeeper deployment CPU limit (default: no limit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We will look into removing these in the future.

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2023

Checked commit nasark@8bb66a2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2023

Checked commit nasark@8bb66a2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@miq-bot miq-bot added the stale label Aug 7, 2023
@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants