[JANSA] Fix oidcAuthIntrospectionURL/oidcClientSecret description #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaishi
changed the title
|
Checked commit simaishi@f27fa1d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint **
|
|
@abellotti can you please review? |
abellotti
reviewed
Aug 10, 2020
| // Only used with the openid-connect authentication type. | ||
| // If not specified, the operator will attempt to fetch its value from the | ||
| // "token_introspection_endpoint" field in the Provider metadata at the | ||
| // OIDCProviderURL provided. | ||
| // +optional | ||
| OIDCOAuthIntrospectionURL string `json:"oidcAuthIntrospectionURL"` | ||
| // Secret name containing the OIDC client id and secret | ||
| // Only used with the openid-connect authentication type |
There was a problem hiding this comment.
Because #582 updated the description at wrong places.
In the original PR for master branch (#571), oidcAuthIntrospectionURL wad updated. But in the Jansa specific PR (#582), oidcClientSecret was updated instead.
So this PR is putting back oidcClientSecret to what it was before #582 and also updating oidcAuthIntrospectionURL to what it should be now.
I noticed this because backporting #606 to jansa branch conflicted.
|
this is fine other than the question about that one diff. Also, this will be updated when #606 gets merged to Jansa. |
abellotti
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #582 (backport of #571) - looks like that PR added description to wrong variables.