Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to gate deploying kafka and zookeeper #543

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

carbonin
Copy link
Member

The application doesn't actually rely on these services so we don't
need to deploy them by default.

If a user wants events published to kafka they can still enable the
flag on deploy and consume those events from a separate application.

Requires ManageIQ/manageiq#20268
Fixes #541

The application doesn't actually rely on these services so we don't
need to deploy them by default.

If a user wants events published to kafka they can still enable the
flag on deploy and consume those events from a separate application.

Requires ManageIQ/manageiq#20268
Fixes ManageIQ#541
@carbonin carbonin requested a review from bdunne as a code owner June 10, 2020 15:53
@bdunne bdunne merged commit 1e9c2d4 into ManageIQ:master Jun 10, 2020
simaishi pushed a commit that referenced this pull request Jun 11, 2020
Add a flag to gate deploying kafka and zookeeper

(cherry picked from commit 1e9c2d4)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit c44a92c3836c3af7c3745ac6953f34460b2b546b
Author: Brandon Dunne <[email protected]>
Date:   Wed Jun 10 14:39:41 2020 -0400

    Merge pull request #543 from carbonin/gate_kafka_install

    Add a flag to gate deploying kafka and zookeeper

    (cherry picked from commit 1e9c2d46f80a06d7cd2d609006249776eca2fae4)

@carbonin carbonin deleted the gate_kafka_install branch June 15, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we remove kafka and zookeeper from Jansa?
4 participants