Add IMAGE_PULL_SECRET parameter #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just complicates things if we want to reference the deployment or container by name for a limited benefit as we're expecting to be the only application in the namespace
|
Merge with ManageIQ/manageiq#19856 |
This is provided to the orchestrator as an image pull secret and also as an environment variable so that it can deploy the worker containers with the same secret. ManageIQ/manageiq#19699
carbonin
force-pushed
the
add_optional_pull_secret
branch
from
ad67d58 to
05c892c
Compare
|
Checked commits carbonin/manageiq-pods@485711b~...05c892c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint **
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a parameter for a secret name to be used for the orchestrator and worker images.
This secret should be pre-created and contain the credentials for the registry specified in the
ORCHESTRATOR_IMAGE_NAMESPACEparameter.Additionally it removes the app name prefix for the orchestrator deployment.
ManageIQ/manageiq#19699