Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby, node and postgresql #326

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Update ruby, node and postgresql #326

merged 3 commits into from
Aug 2, 2019

Conversation

simaishi
Copy link
Contributor

@simaishi simaishi commented Aug 2, 2019 •
edited
Loading

The first PR to get master/ivanchuk up-to-date... Updated ruby, node and postgresql packages and a few minor cleanups.

Trying to make just enough changes to get monolithic (which is built on top of podified) up and running first. So podified will still not work...

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2019

Checked commits simaishi/manageiq-pods@a029839~...2b60784 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@simaishi simaishi mentioned this pull request Aug 2, 2019
Merged
carbonin
carbonin reviewed Aug 2, 2019
View reviewed changes
images/miq-app/Dockerfile
@@ -53,8 +49,7 @@ RUN yum -y install centos-release-scl-rh \
openscap-scanner \
patch \
psmisc \
rh-postgresql95-postgresql-devel \
rh-postgresql95-postgresql-libs \
postgresql-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this versioned? Where are we getting this from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our copr repo: https://copr.fedorainfracloud.org/coprs/manageiq/ManageIQ-Master/packages/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, just found that ... do we want to rebuild it at some point? We're a few versions behind.

Oh, also we probably need to create an Ivanchuk repo, but this is fine we can merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ivanchuk repo is already created. Didn't know we're already behind on version!!! Will take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, think we're at 10.6 and 10.9 was released in June.

@carbonin carbonin merged commit 4041a80 into ManageIQ:master Aug 2, 2019
@carbonin carbonin added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 2, 2019
@carbonin carbonin self-assigned this Aug 2, 2019
@simaishi simaishi deleted the master_ivanchuk_updates branch August 2, 2019 19:48
simaishi pushed a commit that referenced this pull request Aug 2, 2019
@carbonin @simaishi
Merge pull request #326 from simaishi/master_ivanchuk_updates
96b1967 
Update ruby, node and postgresql

(cherry picked from commit 4041a80)
@simaishi
Copy link
Contributor Author

simaishi commented Aug 2, 2019

Ivanchuk backport details:

$ git log -1
commit 96b196732e91d0a44b18b9021c723820e5d959f6
Author: Nick Carboni <[email protected]>
Date:   Fri Aug 2 15:47:03 2019 -0400

    Merge pull request #326 from simaishi/master_ivanchuk_updates
    
    Update ruby, node and postgresql
    
    (cherry picked from commit 4041a80af69ea473826d396e5f8635294a4858b3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

Assignees

@carbonin carbonin

Labels
changelog/yes enhancement ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simaishi @miq-bot @carbonin