Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from apache module mod_auth_kerb to mod_auth_gssap #314

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Nov 16, 2018

https://www.pivotaltracker.com/n/projects/1610127/stories/160297262

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650583

This PR is one of two that will implement moving external authentication support from
the Apache module mod_auth_kerb to mod_auth_gssapi for the Openshift/podified build

The other PR is:
ManageIQ/container-httpd#38

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

@miq-bot add_label enhancement

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

@miq-bot assign @abellotti

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

@miq-bot add_label hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2018

@jvlcek 'abellotti' is an invalid assignee, ignoring...

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

The hammer PR is: #313

@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2018

Checked commit jvlcek@ec00ca1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2018

@jvlcek 'abellotti' is an invalid assignee, ignoring...

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

@miq-bot assign @carbonin

@jvlcek
Copy link
Member Author

jvlcek commented Nov 16, 2018

Although this #314 may cleanly cherry-pick to hammer, because the templates are so different between master and hammer I went ahead and created the hammer specific PR here: #313. Just to be ready in case is doesn't cleanly cherry-pick

If these changes cleanly cherry-pick to hammer then #313 can be closed.

@carbonin carbonin merged commit 16fa6d6 into ManageIQ:master Nov 16, 2018
@carbonin carbonin added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 16, 2018
simaishi pushed a commit that referenced this pull request Nov 16, 2018
Move from apache module mod_auth_kerb to mod_auth_gssap

(cherry picked from commit 16fa6d6)

https://bugzilla.redhat.com/show_bug.cgi?id=1650583
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit b85250e9a1ff1f370dc4b2761640bdcc5043c700
Author: Nick Carboni <[email protected]>
Date:   Fri Nov 16 11:47:19 2018 -0500

    Merge pull request #314 from jvlcek/mod_auth_gssapi_master
    
    Move from apache module mod_auth_kerb to mod_auth_gssap
    
    (cherry picked from commit 16fa6d6f84174ae8743ea666e190076bb49a2538)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1650583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants