Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rolebindings for the orchestrator to the templates #271

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

carbonin
Copy link
Member

These can be created as template objects rather than making the user create them manually through the command line.

@miq-bot
Copy link
Member

miq-bot commented Feb 20, 2018

Checked commits carbonin/manageiq-pods@e0e93a3~...4c7b784 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@bdunne bdunne merged commit 608e725 into ManageIQ:master Feb 20, 2018
@bdunne bdunne added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 20, 2018
@carbonin
Copy link
Member Author

This also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550212 which was reported after this PR was merged.

simaishi pushed a commit that referenced this pull request Mar 23, 2018
Add rolebindings for the orchestrator to the templates
(cherry picked from commit 608e725)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552291
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d7ea10ec1ef28dd348d8ff07e7c57f04f07ad32b
Author: Brandon Dunne <[email protected]>
Date:   Tue Feb 20 14:58:17 2018 -0500

    Merge pull request #271 from carbonin/add_role_bindings_to_template
    
    Add rolebindings for the orchestrator to the templates
    (cherry picked from commit 608e7257192d734b7153c2b8af3dbdab63cccb5f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552291

@carbonin carbonin deleted the add_role_bindings_to_template branch April 7, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants