Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount the configmap into the directory the new image expects #264

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Feb 6, 2018

This will be included into the main postgresql.conf automatically.
Because this path is tied directly to the implementation, there is no reason to expose it to the user as a parameter.

Requires ManageIQ/container-postgresql#8

https://bugzilla.redhat.com/show_bug.cgi?id=1540957

This will be included into the main postgresql.conf automatically.
Because this path is tied directly to the implementation, there is no
reason to expose it to the user as a parameter.

https://bugzilla.redhat.com/show_bug.cgi?id=1540957
@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commit carbonin@4529086 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@JPrause
Copy link
Member

JPrause commented Feb 7, 2018

@bdunne I see GreggT approved, is this ready to be merged. This for a blocker issue.

@bdunne bdunne merged commit 6447370 into ManageIQ:master Feb 7, 2018
@bdunne bdunne added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 7, 2018
simaishi pushed a commit that referenced this pull request Feb 7, 2018
Mount the configmap into the directory the new image expects
(cherry picked from commit 6447370)

https://bugzilla.redhat.com/show_bug.cgi?id=1540957
@simaishi
Copy link
Contributor

simaishi commented Feb 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 759f7a69351b039522b2e94b1e61012e098f07ce
Author: Brandon Dunne <[email protected]>
Date:   Wed Feb 7 12:05:06 2018 -0500

    Merge pull request #264 from carbonin/fix_pg_pod
    
    Mount the configmap into the directory the new image expects
    (cherry picked from commit 6447370d0cbc3bba16ad03f9ce9bb004f758d634)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1540957

@carbonin carbonin deleted the fix_pg_pod branch February 19, 2018 21:39
openshift-merge-robot pushed a commit to openshift/openshift-ansible that referenced this pull request Feb 21, 2018
openshift-merge-robot added a commit to openshift/openshift-ansible that referenced this pull request Feb 21, 2018
Automatic merge from submit-queue.

Update CloudForms 4.6 templates for configmap mount and GA image location

- Change templates to mount the configmap into the directory the new image expects.
ManageIQ/manageiq-pods#264

- Changed image location from Beta to GA (images won't become available until CF 4.6 goes GA)
leseb pushed a commit to leseb/openshift-ansible that referenced this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants