-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount the configmap into the directory the new image expects #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be included into the main postgresql.conf automatically. Because this path is tied directly to the implementation, there is no reason to expose it to the user as a parameter. https://bugzilla.redhat.com/show_bug.cgi?id=1540957
Checked commit carbonin@4529086 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
gtanzillo
approved these changes
Feb 6, 2018
@bdunne I see GreggT approved, is this ready to be merged. This for a blocker issue. |
bdunne
approved these changes
Feb 7, 2018
simaishi
pushed a commit
that referenced
this pull request
Feb 7, 2018
Mount the configmap into the directory the new image expects (cherry picked from commit 6447370) https://bugzilla.redhat.com/show_bug.cgi?id=1540957
Gaprindashvili backport details:
|
openshift-merge-robot
pushed a commit
to openshift/openshift-ansible
that referenced
this pull request
Feb 21, 2018
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Feb 21, 2018
Automatic merge from submit-queue. Update CloudForms 4.6 templates for configmap mount and GA image location - Change templates to mount the configmap into the directory the new image expects. ManageIQ/manageiq-pods#264 - Changed image location from Beta to GA (images won't become available until CF 4.6 goes GA)
leseb
pushed a commit
to leseb/openshift-ansible
that referenced
this pull request
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be included into the main postgresql.conf automatically.
Because this path is tied directly to the implementation, there is no reason to expose it to the user as a parameter.
Requires ManageIQ/container-postgresql#8
https://bugzilla.redhat.com/show_bug.cgi?id=1540957