Enhance app-frontend probes #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reconfigure liveness probe to use PID check of MIQ server process - Reconfigure readiness probe to use TCP check on port 80 instead of HTTP code check - Initial probe delays were not modified
|
Checked commit fbladilo@b1cf5de with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PID check is more effective, specially on initial deployments, liveness will succeed as long as MIQ Server is alive, this would prevent OpenShift from killing/restarting the pod unnecessarily when MIQ server is actually in the final stages of seeding and about to come up.
The initial delays for each probe were kept intact, these are heavily dependent on the performance of cluster nodes assigned for a MIQ deployment. Currently 3 mins for readiness and 8 mins for liveness.