Rename API redirects httpd conf file #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes along with the changes in ManageIQ/manageiq-appliance#131
Fryguy
reviewed
Sep 25, 2017
| @@ -12,7 +12,7 @@ Options SymLinksIfOwnerMatch | |||
| <VirtualHost *:80> | |||
| DocumentRoot /var/www/miq/vmdb/public | |||
| Include conf.d/manageiq-redirects-ui | |||
| Include conf.d/manageiq-redirects-ws | |||
| Include conf.d/manageiq-redirects-api | |||
There was a problem hiding this comment.
In the other repo, I think there was an ordering issue that forced me to put api before ui, so that should be done here as well.
There was a problem hiding this comment.
I imagine it wouldn't matter. This is working now and you didn't change the ordering in the PR where you made the name change right?
There was a problem hiding this comment.
I ensured the ordering was api, then ui, then websocket because that's what it was. I remember @bdunne saying order was important (though I don't know why).
|
Checked commits carbonin/manageiq-pods@c8c936f~...920f6f4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Oct 6, 2017
|
🎉 Thanks @bdunne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along with the changes in ManageIQ/manageiq-appliance#131
This should be merged after that patch so that the file actually exists.