Allow server to control ansible pods #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Jul 3, 2017
| @@ -149,6 +153,11 @@ objects: | |||
| mountPath: "/persistent" | |||
| env: | |||
| - | |||
| name: MY_POD_NAMESPACE | |||
There was a problem hiding this comment.
I think you need this in the other template as well.
This utilizes the OpenShift "Downward API" ref: https://docs.openshift.org/latest/dev_guide/downward_api.html#dapi-values-using-environment-variables
This account will be given the view and edit role for the namespace to allow it to scale the ansible pod when the role is enabled or disabled.
We will scale the pod up to 1 when the role is activated
We use a new user (service account) so that only pods which need API access to the project can get it. For now this will be just the manageiq app pod which will use the API (and the service account token) to scale up or down the ansible pod.
carbonin
force-pushed
the
allow_server_to_control_ansible_pods
branch
from
266eecf to
cd296dd
Compare
|
Checked commits carbonin/manageiq-pods@6c9133b~...cd296dd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new service account for the manageiq application pod which is intended to have edit and view roles for the namespace the project is running in.
This will allow the app pod itself to scale other pods within the project up and down.
The plan is to use this ability to only scale the ansible pod when it is needed (when the role is enabled).