Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version 0.14.0 of the 'ovirt' gem #7

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Use version 0.14.0 of the 'ovirt' gem #7

merged 1 commit into from
Nov 21, 2016

Conversation

jhernand
Copy link
Contributor

This patch changes the Gemfile so that it uses version 0.14.0 of the
'ovirt' gem, as this is needed in order to fix several issues with hot
pulgging of memory in oVirt.

Note that this depends on ManageIQ/ovirt/pull/72, as that is the pull
that makes the required changes to the ovirt gem and bumps the
version number to 0.14.0.

@jhernand jhernand changed the title User verson 0.14.0 of the 'ovirt' gem User version 0.14.0 of the 'ovirt' gem Nov 14, 2016
@jhernand jhernand changed the title User version 0.14.0 of the 'ovirt' gem Use version 0.14.0 of the 'ovirt' gem Nov 16, 2016
@jhernand
Copy link
Contributor Author

@bdunne, @durandom please review.

@jhernand
Copy link
Contributor Author

Note that this can't be merged till version 0.14.0 of the ovirt gem is released, see ManageIQ/ovirt/pull/72.

@jhernand
Copy link
Contributor Author

@jhernand
Copy link
Contributor Author

@Fryguy Fryguy closed this Nov 18, 2016
@Fryguy Fryguy reopened this Nov 18, 2016
@Fryguy Fryguy closed this Nov 18, 2016
@Fryguy Fryguy reopened this Nov 18, 2016
@Fryguy
Copy link
Member

Fryguy commented Nov 18, 2016

Please rebase now that the repo has Travis support.

This patch changes the Gemfile so that it uses version 0.14.0 of the
'ovirt' gem, as this is needed in order to fix several issues with hot
pulgging of memory in oVirt.
@jhernand
Copy link
Contributor Author

Rebased. Note it will fail as version 0.14.0 of the ovirt gem hasn't been released yet.

@bdunne bdunne closed this Nov 21, 2016
@bdunne bdunne reopened this Nov 21, 2016
@bdunne bdunne merged commit 95bad51 into ManageIQ:master Nov 21, 2016
@jhernand
Copy link
Contributor Author

@miq-bot add_label euwe/yes

Note that this is a pre-requisite for the backport of ManageIQ/manageiq/pull/12550.

@simaishi
Copy link
Contributor

@jhernand Can you please create Euwe PR as gemspec doesn't exist in Euwe?

@jhernand
Copy link
Contributor Author

@simaishi this is the equivalent pull request for Euwe: ManageIQ/manageiq#13425

@simaishi
Copy link
Contributor

Backported to Euwe via ManageIQ/manageiq#13425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants