Upgrade rexml to 3.3.3+ for CVE-2024-41123 and CVE-2024-41946 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ManageIQ#581 I wrote > I expect in the future REXML will fail on these leading text nodes, > so we may have to revisit this at that time. and that has now happened in rexml 3.3.3, so this commit also removes the spec for leading text nodes, since they can no longer be parsed. The BOM test ensures that the leading BOM marker is not treated as a text node.
Fryguy
added
dependencies
radjabov/yes?
security fix
|
Checked commit Fryguy@f8daeab with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Backported to radjabov via merge of master into radjabov branch |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Oct 2, 2024
Upgrade rexml to 3.3.3+ for CVE-2024-41123 and CVE-2024-41946 (cherry picked from commit aa3f5b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #581 I wrote
and that has now happened in rexml 3.3.3 (ruby/rexml#184), so this commit also removes the spec for leading text nodes, since they can no longer be parsed. The BOM test ensures that the leading BOM marker is not treated as a text node.
@jrafanie Please review.