Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URI::DEFAULT_PARSER escape/unescape to avoid ruby 2.7 warnings #515

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

jrafanie
Copy link
Member

Fixes various warnings of this variety:
app/models/file_depot_ftp.rb:128: warning: URI.escape is obsolete
app/models/mixins/file_depot_mixin.rb:42: warning: URI.escape is obsolete

From: ManageIQ/manageiq#21036

Related: ManageIQ/manageiq#19678

Fixes various warnings of this variety:
app/models/file_depot_ftp.rb:128: warning: URI.escape is obsolete
app/models/mixins/file_depot_mixin.rb:42: warning: URI.escape is obsolete

From: ManageIQ/manageiq#21036

Related: ManageIQ/manageiq#19678
@jrafanie jrafanie requested a review from NickLaMuro February 16, 2021 17:10
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2021

Checked commit jrafanie@3bddaa4 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
5 files checked, 42 offenses detected

lib/gems/pending/util/mount/miq_generic_mount_session.rb

  • ⚠️ - Line 330, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
  • ⚠️ - Line 330, Col 29 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
  • ⚠️ - Line 330, Col 35 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
  • ⚠️ - Line 330, Col 52 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
  • ⚠️ - Line 330, Col 60 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
  • ⚠️ - Line 330, Col 67 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 17 - Lint/UselessAssignment - Useless assignment to variable - userinfo_log. Use _ or _userinfo_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 41 - Lint/UselessAssignment - Useless assignment to variable - port_log. Use _ or _port_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 51 - Lint/UselessAssignment - Useless assignment to variable - registry_log. Use _ or _registry_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 76 - Lint/UselessAssignment - Useless assignment to variable - opaque_log. Use _ or _opaque_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 88 - Lint/UselessAssignment - Useless assignment to variable - query_log. Use _ or _query_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 331, Col 99 - Lint/UselessAssignment - Useless assignment to variable - fragment_log. Use _ or _fragment_log as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 23 - Lint/UselessAssignment - Useless assignment to variable - host. Use _ or _host as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 29 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 35 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 5 - Lint/UselessAssignment - Useless assignment to variable - scheme. Use _ or _scheme as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 51 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 59 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
  • ⚠️ - Line 460, Col 66 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 23 - Lint/UselessAssignment - Useless assignment to variable - host. Use _ or _host as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 29 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 35 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 45 - Lint/UselessAssignment - Useless assignment to variable - share. Use _ or _share as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 52 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 60 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
  • ⚠️ - Line 81, Col 67 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.

lib/gems/pending/util/mount/miq_nfs_session.rb

  • ⚠️ - Line 15, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 30 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 36 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 5 - Lint/UselessAssignment - Useless assignment to variable - scheme. Use _ or _scheme as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 59 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 67 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
  • ⚠️ - Line 15, Col 74 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.

lib/gems/pending/util/mount/miq_smb_session.rb

  • ⚠️ - Line 17, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 30 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 36 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 5 - Lint/UselessAssignment - Useless assignment to variable - scheme. Use _ or _scheme as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 59 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 67 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
  • ⚠️ - Line 17, Col 74 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.

@Fryguy Fryguy merged commit fbcaf76 into ManageIQ:master Feb 16, 2021
@Fryguy Fryguy added the cleanup label Feb 16, 2021
@Fryguy Fryguy self-assigned this Feb 16, 2021
@jrafanie jrafanie deleted the replace_uri_decode_for_ruby_2_7 branch September 7, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants