[PostgresAdmin] Fix backup_type being ignored #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to add a test to this real quick, since this took me WAY to long to debug yesterday... 😩 Update: Done! (that was easier than expected 😏 ) |
With the previous implementation, the code would always attempt to find the magic number of the file for a `pg_dump` before checking if the `backup_type` value was instead a `:basebackup`. When streaming a file, this would cause it to fail farther down the line since it would have strip some of the content off from the beginning of the file, invalidating it as a proper backup. This change fixes by forcing the check for the backup type first to avoid reading the file data if possible, and then by inspecting the file contents when as a backup option.
NickLaMuro
force-pushed
the
fix-backup-type-checking-for-postgres-admin
branch
from
caf0f38 to
5b9e017
Compare
carbonin
approved these changes
Nov 8, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 12, 2018
…postgres-admin [PostgresAdmin] Fix backup_type being ignored (cherry picked from commit 2276ef7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a FIXUP to #402
With the previous implementation, the code would always attempt to find the magic number of the file for a
pg_dumpbefore checking if thebackup_typevalue was instead a:basebackup. When streaming a file, this would cause it to fail farther down the line since it would have strip some of the content off from the beginning of the file, invalidating it as a proper backup.This change fixes by forcing the check for the backup type first to avoid reading the file data if possible, and then by inspecting the file contents when as a backup option.