[MiqGenericMountSession] Support @byte_count in #download_single #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
support-byte-count-for-mount-filesystems
branch
from
9416cd2 to
6b83b7e
Compare
NickLaMuro
force-pushed
the
support-byte-count-for-mount-filesystems
branch
from
6b83b7e to
85e1a97
Compare
|
Checked commit NickLaMuro@85e1a97 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Nov 5, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
…filesystems [MiqGenericMountSession] Support @byte_count in #download_single (cherry picked from commit 63c7f1a)
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
MiqGenericMountSession#download_singleto support thebyte_countattribute. If passed, it will only download the specified number of bytes to thedestination.Since we are using
IO.copy_stream, this is fairly straight forward, and works with basically anyIO-like object.: