Leverage run_session for SFTP

[ghost]

This PR leverages the run_session method to get a Net::SSH::Connection::Session object that can be used to access the SFTP subsystem. This standardize connection via SSH.

[ghost]

@miq-bot add-reviewer carbonin

[carbonin]

This seems like an odd change, and I can't find documentation for getting to an sftp connection using the ssh session object and also this:

[7] pry(main)> Net::SSH::Connection::Session.instance_methods.include?(:sftp)
=> false
[8] pry(main)> Net::SSH::Connection::Session.methods.include?(:sftp)
=> false

I trust that you've tested this, but I'm not comfortable making this change which doesn't really bring any upside when I can't find this behavior documented anywhere.

[carbonin]

That said, if you can find the documentation for this, then this looks good to me.

[ghost]

I found it here https://net-ssh.github.io/net-sftp/classes/Net/SSH/Connection/Session.html.

[carbonin]

Ah okay, I needed to also require 'net/sftp' because it patches.

[2] pry(main)> require 'net/ssh'
=> true
[3] pry(main)> Net::SSH::Connection::Session.instance_methods.include?(:sftp)
=> false
[4] pry(main)> require 'net/sftp'
=> true
[5] pry(main)> Net::SSH::Connection::Session.instance_methods.include?(:sftp)
=> true

Makes sense to me then 👍

[carbonin]

@fdupont-redhat is there anything that needs this change for the Hammer branch? I'm not sure that this actually adds any functionality, so I'm tempted to label hammer/no.

[ghost]

@carbonin AFAIK, there's no code depending on that change in Hammer. So ok for hammer/no.