Fixed to validate attributes before inserting into XML. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit hsong-rh@5aa3f3d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@hsong-rh this looks good as far as it goes. However my question would be - are there other places in this class where we are assuming valid character encoding that might also be a problem? ".to_s" is used in several places here - what would happen if any of those objects were also in a non-valid encoding? |
|
@jerryk55, we already have a fix for elements adding, here we do the same thing for attributes. These should cover the most cases. |
roliveri
approved these changes
Mar 9, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2018
Fixed to validate attributes before inserting into XML. (cherry picked from commit 21bbb2d) https://bugzilla.redhat.com/show_bug.cgi?id=1554343
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2018
Fixed to validate attributes before inserting into XML. (cherry picked from commit 21bbb2d) https://bugzilla.redhat.com/show_bug.cgi?id=1554344
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out the unrecognized characters in attributes before inserting into XML.
https://bugzilla.redhat.com/show_bug.cgi?id=1533843