Change log_hashes to log hash-like objects properly #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that before it would log with lots of internal structure, and now it logs more like a hash which is cleaner to read. |
|
Checked commit Fryguy@0316bcc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Sep 7, 2017
The event catcher runner was printing the blacklisted events array using the VMDBLogger#log_hashes method. Now that this method calls .to_hash on the argument (ManageIQ/manageiq-gems-pending#268) this is throwing an exception for non-hash type arguments. Instead of using log_hashes just log the elements of the array joined by newlines directly.
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Change log_hashes to log hash-like objects properly (cherry picked from commit 2270f3d) https://bugzilla.redhat.com/show_bug.cgi?id=1531146
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also log Config::Options properly, but I didn't want to include the config gem because it messes with global state. HWIA showed the same problems, and active support is already a dependency, so it will suffice.