Include tracking_label for vmdb-logger

[kbrock]

In workers, we have a global variable $_miq_worker_current_msg that holds the current MiqQueue message being processed. This puts a common identifier in logs to help find related logging messages.

We are transitioning away from task_id for MiqQueue because the concept is not transferrable to other queuing technologies.

This change allows us to still have a global tracking label/identifier. It also lets us get away from a global that is very implementation specific.

Also, it allows us to get away from using task_id in some areas of code that don't need it, and still get the benefits of having a common identifier in the logs.

This is related to ManageIQ/manageiq#15224

In the future, using an mdc for the log may be a better approach. This PR was just focused on removing the MiqQueue dependency and providing backwards compatibility.

[kbrock]

If you want me to remove the global here, then we can make this change in lock step with the one on manageiq/manageiq. up to you.

Also, let me know if you want to change the variable name request_id.

I chose the name request_id, because most of the versions of this code use request.uuid and call it request_id. While this name looks to be based upon an http request, it can also be generated in a scheduler or event stream.

[miq-bot]

Checked commit kbrock@507d4c7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

lib/gems/pending/util/vmdb-logger.rb

• ❗ - Line 162, Col 58 - Style/GlobalVars - Do not introduce global variables.

[mkanoor]

👍
@Fryguy please review