Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to return VM Hardware #148

Merged
merged 2 commits into from
May 4, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented May 2, 2017

When reconfiguring a VM there are a number of steps that need to operate on the VM's config.hardware hash. Add a method to retrieve this once and allow it to be passed in to other methods to reduce the number of retrieveProperties calls made to the provider.

https://bugzilla.redhat.com/show_bug.cgi?id=1445874

@agrare agrare changed the title Bz 1445874 return vm hardware Add method to return VM Hardware May 2, 2017
@agrare agrare force-pushed the bz_1445874_return_vm_hardware branch from 67d174b to 7e13304 Compare May 3, 2017 16:20
@blomquisg blomquisg merged commit 6e38517 into ManageIQ:master May 4, 2017
@blomquisg
Copy link
Member

I set this to fine/no b/c the BZ didn't request it. I could just as easily see this going into a Fine point release, if anyone wants it.

@agrare agrare deleted the bz_1445874_return_vm_hardware branch May 4, 2017 18:49
@agrare agrare added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@simaishi simaishi added euwe/yes and removed fine/no labels May 18, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit df76a520dd47977fcd2358dd1b980846202eec99
Author: Greg Blomquist <[email protected]>
Date:   Thu May 4 14:19:14 2017 -0400

    Merge pull request #148 from agrare/bz_1445874_return_vm_hardware
    
    Add method to return VM Hardware
    (cherry picked from commit 6e38517e8be67f5310e19f843a9fb306e0da7d4b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1452172

simaishi pushed a commit that referenced this pull request Jun 6, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Fine backport details:

$ git log -1
commit b06c7b2601b7f038bc8a46d2bd2e87d4c6d8ac56
Author: Greg Blomquist <[email protected]>
Date:   Thu May 4 14:19:14 2017 -0400

    Merge pull request #148 from agrare/bz_1445874_return_vm_hardware
    
    Add method to return VM Hardware
    (cherry picked from commit 6e38517e8be67f5310e19f843a9fb306e0da7d4b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants