Truncating log messages when they are too large

ManageIQ · Nov 21, 2017 · ad4fb78 · ad4fb78
1 parent bc37126
commit ad4fb78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/gems/pending/util/vmdb-logger.rb b/lib/gems/pending/util/vmdb-logger.rb
@@ -156,8 +156,9 @@ class Formatter < Logger::Formatter
     FORMAT = "[----] %s, [%s#%d:%x] %5s -- %s: %s\n"
 
     def call(severity, time, progname, msg)
-      msg = prefix_task_id(msg2str(msg))
+      max_log_line_length = 1.megabyte
 
+      msg = prefix_task_id(msg2str(msg)).truncate(max_log_line_length)
       FORMAT % [severity[0..0], format_datetime(time), $PROCESS_ID, Thread.current.object_id, severity, progname, msg]
     end
 

diff --git a/spec/util/vmdb-logger_spec.rb b/spec/util/vmdb-logger_spec.rb
@@ -95,6 +95,12 @@
     expect(VMDBLogger.contents("mylog.log")).to eq("")
   end
 
+  context "long messages" do
+    it "truncates long messages when max_message_size is set" do
+      # TODO Add test body!
+    end
+  end
+
   context "with evm log snippet with invalid utf8 byte sequence data" do
     before(:each) do
       @log = File.expand_path(File.join(File.dirname(__FILE__), "data/redundant_utf8_byte_sequence.log"))