Skip to content

Commit

Permalink
Store unique set size (USS) in the PSS column
Browse files Browse the repository at this point in the history
https://bugzilla.redhat.com/show_bug.cgi?id=1506737

Unique set size is a better way to detect workers that are growing
unbounded since any memory/reference leaks would be shown in their
uss.  If the server process is large when forking, new workers would
inherit a big pss immediately.

We should really rename the column/hash key to uss.
  • Loading branch information
jrafanie committed Nov 15, 2017
1 parent 76700bd commit 7c1273e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/gems/pending/util/miq-process.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def self.processInfo(pid = nil)
cpu_total /= MiqSystem.num_cpus
percent_cpu = (1.0 * result[:cpu_time]) / cpu_total
result[:percent_cpu] = round_to(percent_cpu * 100.0, 2)
result[:proportional_set_size] = Sys::ProcTable.ps(pid).smaps.pss
result[:proportional_set_size] = Sys::ProcTable.ps(pid).smaps.uss
when :macosx
h = nil
begin
Expand Down

0 comments on commit 7c1273e

Please sign in to comment.