-
Notifications
You must be signed in to change notification settings - Fork 79
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIXUP] Favor uri_to_local_path; delete mnt_point
For MiqLocalMountSession, favor using uri_to_local_path when it does the same thing as `File.join(mnt_point, relative_to_mount(remote_file))`, which saves a decent amount of uncessary code by having to override `mnt_point`. This should behave the same on NFS and SMB as it did previously, but then avoid the code changes for `mnt_point`, which isn't used terribly consistently compared to the instance variable. Ideally, we would want to use avoid the least amount of changes for MiqGenericMountSession as well as the least amount of overrides in MiqLocalMountSession, and I think this does that... I hope.
- Loading branch information
1 parent
c8bfa5b
commit 4877422
Showing
2 changed files
with
5 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters