Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with invalid yaml #1826

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Dec 10, 2024

The backtick is not a valid starting char in YAML, but also we shouldn't use formatting in the YAML, because it won't be redenered properly anyway.

I'm not sure why #1821 went green, but that introduced the issue.

@agrare Please review
cc @qahmed1998

The backtick is not a valid starting char in YAML, but also we shouldn't
use formatting in the YAML, because it won't be redenered properly
anyway.
@agrare
Copy link
Member

agrare commented Dec 10, 2024

Merging on red, possibly running ci.yml on the wrong ref

@agrare agrare merged commit 5d057a6 into ManageIQ:master Dec 10, 2024
1 of 2 checks passed
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Dec 10, 2024
@Fryguy
Copy link
Member Author

Fryguy commented Dec 11, 2024

Backported to radjabov in commit 41b8259.

commit 41b82596e816159df0c6b876f795b2467261c385
Author: Adam Grare <[email protected]>
Date:   Tue Dec 10 12:10:43 2024 -0500

    Merge pull request #1826 from Fryguy/fix_invalid_yaml
    
    Fix issue with invalid yaml
    
    (cherry picked from commit 5d057a67be64daeca63b7ed3ec98d176e4269d36)

Fryguy pushed a commit that referenced this pull request Dec 11, 2024
Fix issue with invalid yaml

(cherry picked from commit 5d057a6)
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants