Add procedure to specify docker pull secret for embedded workflow #1760
Conversation
|
@aileenjackson It seems some bonus whitespace was added - can you remove that throughout the document? For example: should be |
|
@aileenjackson Can you please also update the PR title to more accurately describe the changes? |
|
|
||
| The workflow code must be in the Amazon States Language (ASL) format and follow its supported specifications. For more information about Amazon States Language and its specification, see [Amazon States Language Guide](https://states-language.net/). | ||
| The workflow code must be in the Amazon States Language (ASL) format and follow its supported specifications. For more information about Amazon States Language and its specification, see [Amazon States Language Guide](https://states-language.net/). |
There was a problem hiding this comment.
| The workflow code must be in the Amazon States Language (ASL) format and follow its supported specifications. For more information about Amazon States Language and its specification, see [Amazon States Language Guide](https://states-language.net/). | |
| The workflow code must be in the Amazon States Language (ASL) format and follow its supported specifications. For more information about Amazon States Language and its specification, see [Amazon States Language Guide](https://states-language.net/). |
|
Hey @aileenjackson can you update the PR description and squash the commits since it doesn't appear this specific history is going to be helpful? |
aileenjackson
changed the title
|
|
||
| b) Provide an image pull secret to a podified Kubernetes container, and then add it to a service account | ||
| In order to pull an image from a private registry you have to provide an `ImagePullSecret` to your containers, see [Pull an Image from a Private Registry](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/). {{ site.data.product.title_short }} uses a service account called `manageiq-default` to run containers for your workflows. You can add an `ImagePullSecret` to this service account by following [Add Image Pull Secrets to a service account](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account/). | ||
| In order to pull an image from a private registry you have to provide an `ImagePullSecret` to your containers, see [Pull an Image from a Private Registry](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/). {{ site.data.product.title_short }} uses a service account called {{ site.data.product.workflow_service_account }} to run containers for your workflows. You can add an `ImagePullSecret` to this service account by following [Add Image Pull Secrets to a service account](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account/). |
There was a problem hiding this comment.
@aileenjackson Since this adds {{ site.data.product.workflow_service_account }} I expected to see a change to the _data/product.yml file here as well. Can you please include that file with that change?
There was a problem hiding this comment.
Sure. For IBM docs (infra-mgmt) it's @ https://github.ibm.com/Aileen-Jackson/infra-mgmt-docs/pull/2/commits/74ecbd71f682e670ed0dd3ca00c1e9ff1d8942b7 and for ManageIQ docs it's 01f919f. I did the PR but couldn't seem to add you after the fact. Thanks Aileen
|
Checked commit aileenjackson@876bd8c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Backported to |
Add procedure to specify docker pull secret for embedded workflow (cherry picked from commit cc5de94)
|
@Fryguy Looks good in ManageIQ docs - https://www.manageiq.org/docs/reference/latest/managing_providers/. I presume it will be automatically added to IBM docs also? Thanks Aileen |
Commits included.