Unpack the hash for ruby 3 support #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prior rubies, this hash was unpacked as the only value in an array. Ruby 3 no longer accepts kwargs or implicit hashes as the last argument sent to a method. Since Runner#initialize accepts only kwargs, it's far easier to just change this to unpack the hash into kwargs using double splat. This was tested for for ruby 2.6, 2.7, and 3.0.
Fryguy
approved these changes
Jan 11, 2022
|
@agrare Super-technically this is a breaking change as if anyone was actually passing an Array with a Hash in it, then that will not longer work, but that seems super-unlikely, and wasn't the prescribed way of using it, so I think this is just a patch release fix. |
agrare
approved these changes
Jan 11, 2022
jrafanie
added a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jan 11, 2022
Testing if ManageIQ/manageiq-cross_repo#78 will get pulled in and used for ruby 3 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prior rubies, this hash was unpacked as the only value in an array. Ruby 3 no
longer accepts kwargs or implicit hashes as the last argument sent to a method.
Since Runner#initialize accepts only kwargs, it's far easier to just change this
to unpack the hash into kwargs using double splat.
This was tested for ruby 2.6, 2.7, and 3.0.