Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cross repo tests to ruby 3.1 #108

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 11, 2024

cross repo tests for ui-classic are failing for me.

Locally, running ui-classic tests with ruby 3.0 are failing for me:

Before

cd manageiq-ui-classic
git checkout master
chruby 3.0
bundle exec rake

An error occurred while loading spec_helper.
Failure/Error: Vmdb::Application.initialize!

RuntimeError:
  Application has been already initialized.
# ruby/3.0.6/gems/railties-6.1.7.7/lib/rails/application.rb:390:in `initialize!'
# ruby/3.0.6/gems/railties-6.1.7.7/lib/rails/railtie.rb:207:in `public_send'
# ruby/3.0.6/gems/railties-6.1.7.7/lib/rails/railtie.rb:207:in `method_missing'
# ./spec/manageiq/config/environment.rb:5:in `<top (required)>'
# ruby/3.0.6/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
# ruby/3.0.6/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'
# ruby/3.0.6/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
# ruby/3.0.6/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'

After

cd manageiq-ui-classic
chruby 3.1
bundle exec rake
# It works

@agrare
Copy link
Member

agrare commented Apr 25, 2024

No issue with starting to default to 3.1 but I'd like to add an option for the user to specify a ruby version or set of ruby versions similar to how we have the --test-suite option

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @agrare I think let's merge this, then we can do the change you're suggesting separately in the bot

@agrare agrare merged commit f108722 into ManageIQ:master Apr 25, 2024
6 checks passed
@kbrock kbrock deleted the ruby_31 branch May 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants