Test: Rename: ChargebackRateDetailCurrency -> Currency #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
test_rename_ChargebackRateDetailCurrencyToCurrency
branch
3 times, most recently
from
65ba47d to
e49701a
Compare
lpichler
force-pushed
the
test_rename_ChargebackRateDetailCurrencyToCurrency
branch
3 times, most recently
from
585e10e to
69174ae
Compare
himdel
reviewed
Nov 28, 2019
.travis.yml
Outdated
| @@ -15,5 +15,31 @@ matrix: | |||
| env: | |||
| global: | |||
| - REPOS= | |||
| - CORE_REPO=manageiq#19538 | |||
There was a problem hiding this comment.
should be manageiq@19538 right? (@ vs #)
(according to https://github.com/ManageIQ/manageiq-cross_repo-tests#testing-a-single-repo-in-the-context-of-manageiq-pr-12345)
There was a problem hiding this comment.
A PR should be # a commit/branch/tag should be @
Looks like the readme is wrong, we follow the standard GitHub short format.
There was a problem hiding this comment.
Also CORE_REPO vs GEM_REPOS are no longer necessary, they're combined into just REPOS
lpichler
force-pushed
the
test_rename_ChargebackRateDetailCurrencyToCurrency
branch
3 times, most recently
from
bea678b to
7eac9ba
Compare
lpichler
force-pushed
the
test_rename_ChargebackRateDetailCurrencyToCurrency
branch
from
7eac9ba to
ad4aa50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ/manageiq#19538