Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring cloud orchestration retirement delete_from_vmdb method #91

Merged
merged 2 commits into from
Apr 17, 2017
Merged

Refactoring cloud orchestration retirement delete_from_vmdb method #91

merged 2 commits into from
Apr 17, 2017

Conversation

pkomanek
Copy link
Contributor

Purpose or Intent

Refactoring Cloud/Orchestration/Retirement/StateMachines/delete_from_vmdb.rb method and adding a new spec. This PR is based on the issue bellow.

Links

#8

@miq-bot add_label refactoring

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commits pkomanek/manageiq-content@49ffe36~...602af4c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@pkomanek pkomanek changed the title [WIP]Refactoring cloud orchestration retirement delete_from_vmdb method Refactoring cloud orchestration retirement delete_from_vmdb method Apr 12, 2017
@miq-bot miq-bot removed the wip label Apr 12, 2017
@mkanoor mkanoor merged commit 3a9bd0a into ManageIQ:master Apr 17, 2017
@mkanoor mkanoor added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 17, 2017
simaishi pushed a commit that referenced this pull request Apr 18, 2017
…retirement_delete_from_vmdb_method

Refactoring cloud orchestration retirement delete_from_vmdb method
(cherry picked from commit 3a9bd0a)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0aa8cf23a09de38e2fb63d3a3a342db540ae5af6
Author: Madhu Kanoor <[email protected]>
Date:   Mon Apr 17 17:48:22 2017 -0400

    Merge pull request #91 from pkomanek/refactoring_cloud_orchestration_retirement_delete_from_vmdb_method
    
    Refactoring cloud orchestration retirement delete_from_vmdb method
    (cherry picked from commit 3a9bd0a521be5b97e02e2d702910e37857bdb73f)

@pkomanek pkomanek deleted the refactoring_cloud_orchestration_retirement_delete_from_vmdb_method branch June 5, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants