Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring cloud orchestration postreconfigure method #57

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Refactoring cloud orchestration postreconfigure method #57

merged 2 commits into from
Mar 30, 2017

Conversation

pkomanek
Copy link
Contributor

Purpose or Intent

Refactoring ManageIQ/Cloud/Orchestration/Reconfiguration/StateMachines/Methods.class/methods/postreconfigure.rb method and adding a new spec. This PR is based on the issue bellow.

Links [Optional]

#8

@miq-bot miq-bot added the wip label Feb 20, 2017
mkanoor
mkanoor reviewed Mar 7, 2017
View reviewed changes
...oud/Orchestration/Reconfiguration/StateMachines/Methods.class/__methods__/postreconfigure.rb Outdated

service = $evm.root["service_reconfigure_task"].source
stack = service.orchestration_stack
service = @handle.root["service_reconfigure_task"].source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkomanek
We have to check if the @handle.root['service_reconfigure_task'] has a valid value.
Can we use a pattern like this
https://github.com/ManageIQ/manageiq-content/blob/master/content/automate/ManageIQ/Service/Generic/StateMachines/GenericLifecycle.class/__methods__/execute.rb#L36
and delegate everything to the service method

mkanoor
mkanoor reviewed Mar 7, 2017
View reviewed changes
Copy link
Contributor

@mkanoor mkanoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a function to fetch the service object like
https://github.com/ManageIQ/manageiq-content/blob/master/content/automate/ManageIQ/Service/Generic/StateMachines/GenericLifecycle.class/__methods__/execute.rb#L36

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2017

Checked commits pkomanek/manageiq-content@43246a1~...1bc9e43 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@pkomanek pkomanek changed the title [WIP]Refactoring cloud orchestration postreconfigure method Refactoring cloud orchestration postreconfigure method Mar 9, 2017
@miq-bot miq-bot removed the wip label Mar 9, 2017
@mkanoor mkanoor merged commit 4ec496e into ManageIQ:master Mar 30, 2017
@mkanoor mkanoor added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
simaishi pushed a commit that referenced this pull request Mar 30, 2017
@mkanoor @simaishi
Merge pull request #57 from pkomanek/refactoring_cloud_orchestration_…
e4bff94 
…postreconfigure_method

Refactoring cloud orchestration postreconfigure method
(cherry picked from commit 4ec496e)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit e4bff94b595e0d6ec5322d4221026a89722935c9
Author: Madhu Kanoor <[email protected]>
Date:   Thu Mar 30 17:42:30 2017 -0400

    Merge pull request #57 from pkomanek/refactoring_cloud_orchestration_postreconfigure_method
    
    Refactoring cloud orchestration postreconfigure method
    (cherry picked from commit 4ec496e325887e4875929d0bbd430423c4190dac)

@pkomanek pkomanek deleted the refactoring_cloud_orchestration_postreconfigure_method branch April 3, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

Assignees

@mkanoor mkanoor

Labels
fine/backported refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pkomanek @miq-bot @simaishi @mkanoor @gmcculloug